Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a configurable "fail fast" validation feature #2582

Closed
JohnTimm opened this issue Jul 7, 2021 · 1 comment
Closed

Add support for a configurable "fail fast" validation feature #2582

JohnTimm opened this issue Jul 7, 2021 · 1 comment
Assignees

Comments

@JohnTimm
Copy link
Collaborator

JohnTimm commented Jul 7, 2021

In production, it makes sense to fail fast when the FHIRValidator encounters an issue with an ERROR severity. A configurable "fail fast" validation feature would allow for development with standard behavior and production with a more performant option.

@JohnTimm JohnTimm self-assigned this Jul 7, 2021
JohnTimm added a commit that referenced this issue Jul 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre lmsurpre added this to the Sprint 2021-09 milestone Jul 8, 2021
JohnTimm added a commit that referenced this issue Jul 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 8, 2021
* Issue #2582 - add support for fail-fast validation

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2582 - minor tweak

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Update fhir-validation/src/main/java/com/ibm/fhir/validation/FHIRValidator.java

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>

* Issue #2582 - updates per PR comments

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

Co-authored-by: Lee Surprenant <lmsurpre@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 12, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 12, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 12, 2021
* Issue #2582, #2583 - general refactoring / clean-up

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2582 - minor update to validateProfileReferences method

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 12, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Jul 12, 2021
* Issue #2582, #2583 - additional updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2583 - remove unnecessary parameter

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112
Copy link
Contributor

prb112 commented Jul 12, 2021

Created an Observation without issues
Created an Observation (same starting point without a validQuantity) and FailFast as false
Two Errors present
Created an Observation with same starting point and failFast as true
One Error Present (as expected)

    "resourceType": "OperationOutcome",
    "id": "c0-a8-56-14-d7cf56ff-323d-4b1b-881c-130604e5548f",
    "issue": [
        {
            "severity": "error",
            "code": "invariant",
            "details": {
                "text": "vs-3: If there is no a value a data absent reason must be present"
            },
            "expression": [
                "Observation.component[0]"
            ]
        },
        {
            "severity": "warning",

@prb112 prb112 closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants