-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BulkData: Delete Job #2713
Comments
@dabimahesh Thank you for opening A few questions: With these questions asked, I can more easily replicate your issue locally. |
Hello Paul, 1 - We have one server on ubuntu and we are using Postgre as DB. We are in the process of testing IBM FHIR server on Inferno testing tool
3 - Operation GET (worked fine)
Please let us know if you need any other information. |
Hi Paul I think before looking into above logs, we reviewed the code and found out that the delete job URL is not getting formed correctly. https://fhir.secureit.co.in:9443/ibm/api/batch/**jobexecutions**/85 There is nothing called jobexecutions so it we change to jobinstances it works, so URL should be https://fhir.secureit.co.in:9443/ibm/api/batch/**jobinstances**/85 I think if we change the following code in BulkDataClient.Java it will work. This is just our code review suggestion. Let me know your thoughts. |
Thanks Dabimahesh... I'll look at this... there are a few reasons why it calls jobexecutions as it may have multiple running executions. it's a little bit more complicated than just changing it. I'll definitely consider all the data you have provided and comments. Many thanks |
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Thanks @dabimahesh great find - I confirmed your fix and raised a PR. I'll add an IntegrationTest to confirm. |
Great. How we can get this fix...rather the one fixed in this sprint? Mahesh |
I've been working with the updated implementation and I cannot recreate the There is still some very "interesting" behavior when it comes to stopping ( A DELETE to a completed job is consistently producing the proper result for me (202, followed by a 404--as if the job had never existed). |
Following are different log information when trying to DELETE a job. (4.9.1 version) Message.log trace.log [9/21/21, 10:55:40:073 UTC] 00000042 FHIRResource 1 |
That's right. Your job is not configured with a real operational datastore. There is a default in memory. You can configure using this dropin https://github.com/IBM/FHIR/blob/main/fhir-server/liberty-config/configDropins/disabled/postgres/bulkdata.xml |
We are getting "An unexpected error has occurred while deleting the job", when a DELETE is initiated. Is it that we are missing any configuration?
The text was updated successfully, but these errors were encountered: