Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'requiresAccessToken' configurable in the Bulk Export Status Report #2714

Closed
dabimahesh opened this issue Aug 24, 2021 · 3 comments
Closed
Assignees
Labels
configuration enhancement New feature or request

Comments

@dabimahesh
Copy link

dabimahesh commented Aug 24, 2021

Regarding one more scenario for bulk export

A scenario while testing in Inferno

Request URL:
https://***:9443/fhir-server/api/v4/$bulkdata-status?job=HRheZqFY_KT5TXhdXFuY7g

Response Body:
{
"transactionTime": "2021-08-18T10:21:53.82Z",
"request": "https://***:9443/fhir-server/api/v4/Group/17b58c31108-77f6763e-008b-4010-b428-c42ee061aa57/$export",
"requiresAccessToken": false,
"output": [{
"type": "AllergyIntolerance",
"url": "_jVMAj-5zOenYBhcTN5pa5b6DvR2rsx2Cpv4l9wuXOY/AllergyIntolerance_1.ndjson",
"count": 10
},
{
"type": "CarePlan",
"url": "_jVMAj-5zOenYBhcTN5pa5b6DvR2rsx2Cpv4l9wuXOY/CarePlan_1.ndjson",
"count": 2
}
]
}

This test case is a pass, except that it needs few extra things in the response as mentioned below:

"requiresAccessToken": false. This parameter in the response is false, we need to return this in response as true. We have done all the required changes but are not able to get this. Seems that it is fixed value.
Could you please let us know how to achieve this?

https://chat.fhir.org/#narrow/stream/212434-ibm/topic/releases/near/250499231

@dabimahesh dabimahesh added the bug Something isn't working label Aug 24, 2021
@prb112 prb112 added enhancement New feature or request and removed bug Something isn't working labels Aug 24, 2021
@prb112
Copy link
Contributor

prb112 commented Aug 24, 2021

Marked this as an enhancement.

@prb112 prb112 self-assigned this Aug 24, 2021
@prb112 prb112 added this to the Sprint 2021-11 milestone Aug 24, 2021
@prb112
Copy link
Contributor

prb112 commented Aug 24, 2021

Adding an entry to the storageProviderfhirServer/bulkdata/storageProviders/" + provider + "/requiresAccessToken

prb112 added a commit that referenced this issue Aug 24, 2021
- Bulk Export Status #2715
	- Added a default Error
- Bulk Export Status Report #2714
	- Added property for requiresAccessToken
- Composition reports a 500 when it's a bad user request #2717
	- Mutate 500 to 400 in $document
	- Add Test for $document when bad request

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112 prb112 mentioned this issue Aug 24, 2021
@lmsurpre
Copy link
Member

lmsurpre commented Sep 3, 2021

I confirmed that the "requiresAccessToken" in the output now takes it value from this new config property and that the default is still false.

@lmsurpre lmsurpre closed this as completed Sep 3, 2021
@lmsurpre lmsurpre changed the title Bulk Export Status Report Make 'requiresAccessToken' configurable in the Bulk Export Status Report Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants