AuthzPolicyEnforcement changes #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. getPatientRefValue now uses ReferenceUtil to obtain the id of the target Patient being referenced. This technique matches what we do during the extraction of the compartment membership param and is more robust to special reference values like versioned references or absolute references that match the base server url. 2. getPatientIdFromToken will now split the patient_id claim on spaces. This sets us up for scenarios where a single token can grant access to multiple patient records. Additionally, I removed the log statement about expecting patient_id to be a string and not a list. 3. Patient search is now allowed. Because we convert all searches into compartment searches, there is no longer a risk of exposing whether a given Patient resource by a given id exists or not. Therefore, we don't need to prevent such searches any longer. That said, because a Patient is not in its own compartment (unless it has a corresponding Patient.link), Patient search behavior will likely to be confusing to clients, operators may want to continue to disallow Patient search from the REST layer in select deployments. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
JohnTimm
reviewed
Apr 21, 2021
| return claim.asList(String.class); | ||
| } | ||
|
|
||
| return Collections.singletonList(patientId); | ||
| return Stream.of(patientId.split(" ")) |
There was a problem hiding this comment.
Should we split on \s+ here?
There was a problem hiding this comment.
Good question. I think we're ok with supporting just space-delimited values for now, but do let me know if you feel we should change it.
d0roppe
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPatientRefValue now uses ReferenceUtil to obtain the id of the
target Patient being referenced. This technique matches what we do
during the extraction of the compartment membership param and is more
robust to special reference values like versioned references or absolute
references that match the base server url.
getPatientIdFromToken will now split the patient_id claim on spaces.
This sets us up for scenarios where a single token can grant access to
multiple patient records. Additionally, I removed the log statement
about expecting patient_id to be a string and not a list.
Patient search is now allowed. Because we convert all searches into
compartment searches, there is no longer a risk of exposing whether a
given Patient resource by a given id exists or not. Therefore, we don't
need to prevent such searches any longer. That said, because a Patient
is not in its own compartment (unless it has a corresponding
Patient.link), Patient search behavior will likely to be confusing to
clients and so operators may want to continue to disallow Patient search
from the REST layer in select deployments.
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com