Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user/ scopes #2675

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Add support for user/ scopes #2675

merged 1 commit into from
Aug 11, 2021

Conversation

lmsurpre
Copy link
Member

Importantly, access tokens with user/<resourceType>.<permission>
scopes will now have this permission for all resources of this type.

In most cases, operators using user/ scopes will need to layer on
their own permissions model on top of what is provided in this
authorization interceptor.

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

Copy link
Collaborator

@JohnTimm JohnTimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Importantly, access tokens with `user/<resourceType>.<permission>`
scopes will now have this permission for *all* resources of this type.

In most cases, operators using `user/` scopes will need to layer on
their own permissions model on top of what is provided in this
authorization interceptor.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit d0545fb into main Aug 11, 2021
@lmsurpre lmsurpre deleted the lee-main-2 branch August 11, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants