FHIRPathSpecTest update and related changes #2749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
force-pushed
the
update-fhirpath-tests
branch
2 times, most recently
from
8a71315
to
d5b073f
Compare
lmsurpre
changed the title
1. Update to the latest from https://github.com/FHIR/fhir-test-cases/blob/master/r4/fhirpath/tests-fhir-r4.xml 2. Comment out the test cases we consider to be invalid (and add comments to explain why) 3. Minor fixes to the FHIRPathSpecTest harness 4. Minor fixes to our FHIRPath engine * add guard in FHIRPathAbstractTemporalValue.isComparableTo * FHIRPathEvaluator.exists fix for applying predicate against all context nodes (not just the first one) * Update allTrue() to throw when called with non-boolean inputs * rename private validateEqualityOperands helper Update results: ``` Total tests run: 723, Passes: 544, Failures: 0, Skips: 179 ``` Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
force-pushed
the
update-fhirpath-tests
branch
from
d5b073f
to
66eda23
Compare
JohnTimm
reviewed
Sep 13, 2021
| if (!validateEqualityOperands(left, right)) { | ||
| // for quantity operands: Attempting to operate on quantities with invalid units will result in empty ({ }). | ||
| // for temporal operands: If one input has a value for the precision and the other does not, the comparison stops and the result is empty ({ }) | ||
| if (!isEqualityOperationValid(left, right)) { |
There was a problem hiding this comment.
we are really checking the operands here. I think perhaps:
if (!equalityOperandsValid(left, right))or
if (!equalityOperandsAreValid(left, right))reads a little better.
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/FHIR/fhir-test-cases/blob/master/r4/fhirpath/tests-fhir-r4.xml
comments to explain why)
context nodes (not just the first one)
Update results:
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com