Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve SpatialTransformation #42

Merged
merged 1 commit into from Mar 30, 2019
Merged

Improve SpatialTransformation #42

merged 1 commit into from Mar 30, 2019

Conversation

beat-buesser
Copy link
Collaborator

@beat-buesser beat-buesser commented Mar 29, 2019 •
edited

Description

This pull request improves SpatialTransformation to return unchanged images if classifier is not fooled at all.

Fixes # (issue)

Fixes issue #40

Type of change

Please check all relevant options.

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • Test A
  • Test B

Test Configuration:

  • OS
  • Python version
  • ART version or commit number
  • TensorFlow / Keras / PyTorch / MXNet version

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@beat-buesser beat-buesser mentioned this pull request Mar 29, 2019
Closed
Make sure that SpatialTransformation returns benign samples in case c…
aa4b1fc 
…lassifier is not fooled

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
@ririnicolae ririnicolae self-requested a review March 30, 2019 07:26
ririnicolae
ririnicolae approved these changes Mar 30, 2019
View reviewed changes
Copy link
Collaborator

@ririnicolae ririnicolae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beat-buesser Thanks for fixing the bug!

@ririnicolae ririnicolae self-assigned this Mar 30, 2019
@ririnicolae ririnicolae merged commit 3327181 into Trusted-AI:master Mar 30, 2019
@beat-buesser beat-buesser mentioned this pull request Mar 30, 2019
Merged
13 tasks
ririnicolae pushed a commit that referenced this pull request Apr 1, 2019
@beat-buesser
Make sure that SpatialTransformation returns benign samples in case c…
b812a82 
…lassifier is not fooled (#42, close #40)

Signed-off-by: Beat Buesser <beat.buesser@ie.ibm.com>
(cherry picked from commit 3327181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ririnicolae ririnicolae ririnicolae approved these changes

Assignees

@ririnicolae ririnicolae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beat-buesser @ririnicolae