-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow passing <path:..> as a placeholder #106
Conversation
Codecov Report
@@ Coverage Diff @@
## next #106 +/- ##
=======================================
Coverage ? 51.21%
=======================================
Files ? 15
Lines ? 492
Branches ? 0
=======================================
Hits ? 252
Misses ? 201
Partials ? 39 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot here, but this LGTM. I see that we change how the replacement logic works to allow for pulling from Vault mid-replacement in the case of placeholders containing specific Vault paths. I also see that we pass the annotations along to GetSecrets
to act on them there, and that we use unstructured.Unstructured
from the very beginning to make it easy to make proper k8s resources and serialize back to YAML.
Description
Support passing a placeholder as path:..#key instead of having to use the avp_path. This will using multiple paths in a single file as well as add support for having one secret per path
Fixes: #84 #83
Checklist
Please make sure that your PR fulfills the following requirements:
Type of Change