Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow passing <path:..> as a placeholder #106

Merged
merged 7 commits into from
Apr 9, 2021
Merged

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Mar 26, 2021

Description

Support passing a placeholder as path:..#key instead of having to use the avp_path. This will using multiple paths in a single file as well as add support for having one secret per path

Fixes: #84 #83

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@werne2j werne2j requested a review from jkayani as a code owner March 26, 2021 18:03
@werne2j werne2j self-assigned this Mar 26, 2021
@werne2j werne2j mentioned this pull request Mar 26, 2021
12 tasks
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (next@b81a403). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #106   +/-   ##
=======================================
  Coverage        ?   51.21%           
=======================================
  Files           ?       15           
  Lines           ?      492           
  Branches        ?        0           
=======================================
  Hits            ?      252           
  Misses          ?      201           
  Partials        ?       39           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b81a403...b88e752. Read the comment docs.

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot here, but this LGTM. I see that we change how the replacement logic works to allow for pulling from Vault mid-replacement in the case of placeholders containing specific Vault paths. I also see that we pass the annotations along to GetSecrets to act on them there, and that we use unstructured.Unstructured from the very beginning to make it easy to make proper k8s resources and serialize back to YAML.

@werne2j werne2j merged commit f7b75db into next Apr 9, 2021
@werne2j werne2j deleted the vaultSecretKey branch April 9, 2021 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants