feat: Update annotations to use kubernetes convention #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #114 +/- ##
=======================================
Coverage ? 53.35%
=======================================
Files ? 16
Lines ? 521
Branches ? 0
=======================================
Hits ? 278
Misses ? 202
Partials ? 41 Continue to review full report at Codecov.
|
jkayani
reviewed
Apr 20, 2021
jkayani
reviewed
Apr 20, 2021
cmd/generate.go
Outdated
| @@ -65,7 +65,7 @@ func NewGenerateCommand() *cobra.Command { | |||
| } | |||
|
|
|||
| annotations := manifest.GetAnnotations() | |||
| avpIgnore, _ := strconv.ParseBool(annotations["avp_ignore"]) | |||
| avpIgnore, _ := strconv.ParseBool(annotations["avp.kubernetes.io/ignore"]) | |||
There was a problem hiding this comment.
Missed a spot for using the enum instead of the string
jkayani
reviewed
Apr 20, 2021
pkg/types/constants.go
Outdated
|
|
||
| AVPPathAnnotation = "avp.kubernetes.io/path" | ||
| AVPIgnoreAnnotation = "avp.kubernetes.io/ignore" | ||
| KVVersionAnnotation = "avp.kubernetes.io/kv-version" |
There was a problem hiding this comment.
Doesn't really matter but VaultKVVersionAnnotation might be a better name especially since that only applies to Vault and this plugin now supports non-Vault things
jkayani
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update annotations to follow kubernetes annotation convention
Fixes: #112
Checklist
Please make sure that your PR fulfills the following requirements:
Type of Change