Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use default vault environment variables #94

Merged
merged 3 commits into from
Mar 15, 2021
Merged

feat: Use default vault environment variables #94

merged 3 commits into from
Mar 15, 2021

Conversation

werne2j
Copy link
Member

@werne2j werne2j commented Mar 12, 2021

Description

Support all vault env vars instead of specific ones

Fixes: #85

Checklist

Please make sure that your PR fulfills the following requirements:

  • Reviewed the guidelines for contributing to this repository
  • The commit message follows the Conventional Commits Guidelines.
  • Tests for the changes have been updated
  • Docs have been added / updated

Type of Change

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

@werne2j werne2j requested a review from jkayani as a code owner March 12, 2021 18:52
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #94 (fb6bdf0) into next (c7910af) will decrease coverage by 1.83%.
The diff coverage is 61.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #94      +/-   ##
==========================================
- Coverage   54.46%   52.62%   -1.84%     
==========================================
  Files          15       15              
  Lines         538      534       -4     
==========================================
- Hits          293      281      -12     
- Misses        199      207       +8     
  Partials       46       46              
Impacted Files Coverage Δ
cmd/util.go 65.51% <ø> (+20.06%) ⬆️
pkg/config/config.go 61.03% <59.32%> (-29.59%) ⬇️
cmd/generate.go 68.88% <100.00%> (+2.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7910af...fb6bdf0. Read the comment docs.

Copy link
Member

@jkayani jkayani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@werne2j werne2j merged commit a58a0c6 into next Mar 15, 2021
@werne2j werne2j deleted the vaultEnvVars branch March 15, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants