fix: xccdf to oscal-ar #1336
fix: xccdf to oscal-ar #1336
Conversation
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
Signed-off-by: degenaro <lou.degenaro@gmail.com>
degenaro
requested review from
AleJo2995,
fsuits,
vikas-agarwal76 and
enikonovad
| def test_xccdf_print_info(tmp_path): | ||
| """Test print_info call.""" | ||
| config = setup_config(cf01) | ||
| section = config['task.xccdf-result-to-oscal-ar'] | ||
| section['output-dir'] = str(tmp_path) | ||
| tgt = xccdf_result_to_oscal_ar.XccdfResultToOscalAR(section) | ||
| retval = tgt.print_info() | ||
| assert retval is None | ||
|
|
There was a problem hiding this comment.
A lot of test cases here test similar things, I would recommend looking into @pytest.mark.parametrize to reduce the duplicated tests
There was a problem hiding this comment.
Here's the thing: this is a rework of trestle task osco-result-to-oscal-ar to change its name to xccdf-result-to-oscal-ar. As much as possible I re-used existing data and code. I could upgrade the test cases here as you suggest, but that seems like a different issue than renaming the task. Eventually osco-result-to-oscal-ar should be removed, but that can be saved for the next breaking release. If you agree, I can open another issue to improve existing task test cases, since many already have this same issue.
There was a problem hiding this comment.
Okay, in such case we can leave it until the next time.
|
Issue opened #1362 |
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Both task
osco-result-to-oscal-arandxccdf-result-to-oscal-arcan co-exist. The former can be removed at next major release.Fixes issue #1329
Key links:
Before you merge