Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change lint title action #1352

Merged
merged 48 commits into from
May 12, 2023
Merged

fix: change lint title action #1352

merged 48 commits into from
May 12, 2023

Conversation

AleJo2995
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1348

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@AleJo2995
test bad pr title action change
e3a9f7a 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding current branch to run pr title action
8a61714 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'develop' into fix/change-lint-title-action
0256e6a
@AleJo2995
fix: changing settings for conventional pr title check
e2a53f0 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'fix/change-lint-title-action' of https://github.com/IBM…
56bc855 
…/compliance-trestle into fix/change-lint-title-action
@AleJo2995
Merge branch 'develop' into fix/change-lint-title-action
64b6cb7
@AleJo2995
fix: chaning pr lint flow
15a220d 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'fix/change-lint-title-action' of https://github.com/IBM…
4dd3fab 
…/compliance-trestle into fix/change-lint-title-action
@AleJo2995
fix: correct permissions on folders
c5ea870 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding sudo to apt install
3641958 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding correct branch
7540c4f 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correcting typo
db04be1 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correcting branch
1744c88 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: add step to check
8c0f651 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
bad pr title test (#1356)
d729547 
* bad pr title test

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

* spacing

* fix: adding sudo to apt install

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

* adding space

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

* change readme

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>

* Update README.md

* Update README.md

---------

Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: fixing action condition
00bb378 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'fix/change-lint-title-action' of https://github.com/IBM…
7b15e80 
…/compliance-trestle into fix/change-lint-title-action
@AleJo2995
fix: correct conditional
bc81d18 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: add config conventional install
2482a75 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding commitlint config
2e432df 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: chaning branch to checkout
83fa992 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'develop' into fix/change-lint-title-action
12e4ea8
@AleJo2995
add validation just for title
459373e 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: grab the first commit msg
1f6671c 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding config
1537488 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: add pull request event
4b544b9 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correct action workflow
829f580 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: remove message
74c6590 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding merge commit to check
d445f6d 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: geting latest commit
13c6523 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: setup default branch
f6a45ea 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: fixing syntax error
ae887a9 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: inverting commit order
e9c1577 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: commitlint config
c403e23 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: fixing typo
a56caf0 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correcting typo
2482696 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: fixing typo
68f3e1e 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: missing install
a0ae218 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: adding corrections
c06cb96 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: match pr title
64cbb4e 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: add validation step
dc882b1 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
fix: correct action
401bb8e 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'develop' into fix/change-lint-title-action
fd0a55d
@AleJo2995
fix: change pr title check steps
21eb239 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995
Merge branch 'fix/change-lint-title-action' of https://github.com/IBM…
d165f6c 
…/compliance-trestle into fix/change-lint-title-action
@AleJo2995 AleJo2995 changed the title test bad pr title action change fix: change lint title action May 11, 2023
AleJo2995 and others added 2 commits May 10, 2023 19:37
@AleJo2995
fix: adding correct config
d29599e 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@mrgadgil
fix: fix mdformat errors in readme
f4d7842
mrgadgil
mrgadgil requested changes May 11, 2023
View reviewed changes
.github/workflows/conventional-pr.yml Outdated Show resolved Hide resolved
.github/workflows/conventional-pr.yml Show resolved Hide resolved
@AleJo2995
fix: target main and develop branches
ea9b686 
Signed-off-by: Alejandro Jose Leiva Palomo <alejandro.leiva.palomo@ibm.com>
@AleJo2995 AleJo2995 merged commit 5444206 into develop May 12, 2023
15 checks passed
@AleJo2995 AleJo2995 deleted the fix/change-lint-title-action branch May 12, 2023 14:29
@AleJo2995 AleJo2995 mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgadgil mrgadgil mrgadgil approved these changes

@vikas-agarwal76 vikas-agarwal76 Awaiting requested review from vikas-agarwal76

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update lint pr title check workflow to comply with IBM open-source requirements
2 participants
@AleJo2995 @mrgadgil