Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pydantic 2.0.0 break unit tests #1418

Merged
merged 3 commits into from
Jul 5, 2023
Merged

fix: pydantic 2.0.0 break unit tests #1418

merged 3 commits into from
Jul 5, 2023

Conversation

degenaro
Copy link
Collaborator

@degenaro degenaro commented Jul 3, 2023

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@degenaro
fix: pydantic 2.0.0 break unit tests
1bf2156 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@degenaro
Copy link
Collaborator Author

degenaro commented Jul 3, 2023

Fixes #1416

vikas-agarwal76
vikas-agarwal76 reviewed Jul 4, 2023
View reviewed changes
setup.cfg Outdated
@@ -32,7 +32,7 @@ install_requires =
paramiko
ruamel.yaml
furl
pydantic[email]>=1.8.2
pydantic[email]>1.8.1,<2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@degenaro Make it -
pydantic[email]>=1.8.2,<2.0.0

This way the min. working version will be explicit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

degenaro and others added 2 commits July 4, 2023 11:35
@degenaro
fix minimum pydantic version
24002f6 
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
@AleJo2995
Merge branch 'develop' into fix/pydantic-1.8.2
ac400f6
AleJo2995
AleJo2995 approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@degenaro degenaro merged commit 2138831 into develop Jul 5, 2023
16 checks passed
@degenaro degenaro deleted the fix/pydantic-1.8.2 branch July 5, 2023 11:10
@degenaro degenaro mentioned this pull request Jul 5, 2023
Closed
@AleJo2995 AleJo2995 mentioned this pull request Jul 5, 2023
Closed
degenaro added a commit that referenced this pull request Jul 12, 2023
@degenaro @AleJo2995
fix: pydantic 2.0.0 break unit tests (#1418)
431bca4 
* fix: pydantic 2.0.0 break unit tests

Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>

* fix minimum pydantic version

Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>

---------

Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Co-authored-by: AleJo2995 <alejandro.leiva.palomo@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikas-agarwal76 vikas-agarwal76 vikas-agarwal76 left review comments

@AleJo2995 AleJo2995 AleJo2995 approved these changes

@mrgadgil mrgadgil Awaiting requested review from mrgadgil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@degenaro @AleJo2995 @vikas-agarwal76