fix: default set-parameter values as list #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
vikas-agarwal76
requested changes
Aug 11, 2023
| @@ -576,14 +576,27 @@ def _get_control_implementation( | |||
| component.control_implementations.append(control_implementation) | |||
| return control_implementation | |||
|
|
|||
| def _str_to_list(self, value: str) -> List[str]: | |||
| """List to string.""" | |||
| rval = [] | |||
There was a problem hiding this comment.
The comment should be string to list
trestle/tasks/csv_to_oscal_cd.py
Outdated
| # remove whitespace | ||
| for v in values: | ||
| n = v.replace(' ', '') | ||
| n = n.strip() |
There was a problem hiding this comment.
What is the purpose of both the lines above? Just to remove leading and trailing spaces, or also remove spaces in between? Suppose a single value is a string containing 2 or more words. This will remove spaces in between words also. Is that the intention?
Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
jpower432
pushed a commit
to jpower432/compliance-trestle
that referenced
this pull request
Aug 23, 2023
* fix: default set-parameter values as list Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> * fix string to list comment and blanks removal Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com> --------- Signed-off-by: Lou DeGenaro <lou.degenaro@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
develop->main)Quality assurance (all should be covered).
Summary
Key links:
Before you merge