Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing type definitions for ibm specific fields #34

Closed
hiro5id opened this issue Nov 28, 2018 · 6 comments
Closed

missing type definitions for ibm specific fields #34

hiro5id opened this issue Nov 28, 2018 · 6 comments
Assignees

Comments

@hiro5id
Copy link

hiro5id commented Nov 28, 2018

When I import this package using import AWS = require('ibm-cos-sdk'); then typescript complains about some of the extra IBM specific parameters I have to pass it. For example:

In:

new AWS.S3({
      endpoint: '<endpoint>',
      apiKeyId: '<key>',
      ibmAuthEndpoint: '<auth>',
      serviceInstanceId: '<service-instance>',
    }

The fields apiKeyId, ibmAuthEndpoint and serviceInstanceId do not exist in type 'ClientConfiguration'.

So I have to import it like this for it to work : const AWS = require('ibm-cos-sdk'); but then I lose types.

Perhaps the ServiceConfigurationOptions interface needs to be updated to include these new fields.

@runnerpaul
Copy link

@hiro5id I'll look into this.

Are you using release 1.3.2?

@hiro5id
Copy link
Author

hiro5id commented Nov 28, 2018

Yes, 1.3.2

@hiro5id
Copy link
Author

hiro5id commented Nov 28, 2018

I have created a pull request : #35

@stephenskinner stephenskinner self-assigned this Nov 30, 2018
@stephenskinner
Copy link
Contributor

Hi @hiro5id ,
I've created an internal issue and will get this fixed in the next release. Thanks for the PR.

@virkt25
Copy link

virkt25 commented Dec 3, 2018

@stephenskinner Can we get this PR merged? Would resolve some issues for me as well. Thanks :)

@stephenskinner
Copy link
Contributor

stephenskinner commented Dec 5, 2018

Hi @hiro5id, @virkt25,
This is fixed in our upcoming 1.4.1 node sdk release.
Thanks for the PR, unfortunately we can't merge the PR due to the build release process in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants