Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid 3.4.0 is deprecated #89

Closed
mriedem opened this issue Nov 4, 2021 · 7 comments
Closed

uuid 3.4.0 is deprecated #89

mriedem opened this issue Nov 4, 2021 · 7 comments

Comments

@mriedem
Copy link
Member

mriedem commented Nov 4, 2021

I'm using ibm-cos-sdk 1.10.2 which depends on uuid@3.4.0 which is deprecated:

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

I'm not sure if there is any breaking change in uuid@7 for ibm-cos-sdk but if not it'd be nice to upgrade to avoid that deprecation warning.

@mriedem
Copy link
Member Author

mriedem commented Nov 4, 2021

Also FYI defunctzombie/node-url#57 - if ibm-cos-sdk could get away with not requiring that url dependency and instead use the URL module in nodejs directly that'd be a win IMO.

@sp1tz
Copy link

sp1tz commented Feb 4, 2022

I'm using ibm-cos-sdk 1.10.2 which depends on uuid@3.4.0 which is deprecated:

npm WARN deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

I'm not sure if there is any breaking change in uuid@7 for ibm-cos-sdk but if not it'd be nice to upgrade to avoid that deprecation warning.

Same here. uuid skipped version numbers 4, 5, & 6 to avoid confusion w/ the RFC: https://www.npmjs.com/package/uuid#upgrading-from-uuid3x

A quick grep of the code shows it only used in a single source file: https://github.com/IBM/ibm-cos-sdk-js/blob/master/lib/util.js#L952

All that leads me to believe the update should be straightforward w/o breakage.

@IBMeric
Copy link
Member

IBMeric commented Feb 4, 2022

This change came in too late for the 1.11.0 release but is currently staged for the next one.

@AWare
Copy link

AWare commented May 18, 2022

@IBMeric when is this planned please?

@IBMalok
Copy link
Contributor

IBMalok commented May 19, 2022

@AWare - It will be available at end of the second quarter.

@IBMalok
Copy link
Contributor

IBMalok commented Jun 22, 2022

@AWare We have released 1.12.0 and this issue got addressed. Please verify and close this ticket.

@mriedem
Copy link
Member Author

mriedem commented Jun 22, 2022

We have released 1.12.0 and this issue got addressed. Please verify and close this ticket.

Yup looks good, thanks.

$ npm list uuid
sw-ibmq-results@0.53.2 /home/osboxes/ibmq/sw-ibmq-results
├─┬ ibm-cos-sdk@1.12.0
│ └── uuid@7.0.3 deduped
└── uuid@7.0.3

@mriedem mriedem closed this as completed Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants