Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibm-cos-sdk-js is not fips compliant because it uses crypto-browserify #96

Open
HMhamedminaee opened this issue Nov 2, 2022 · 9 comments

Comments

@HMhamedminaee
Copy link

HMhamedminaee commented Nov 2, 2022

Hi

we are using ibm-cos-sdk-js and we are required to be fips compliant but this library (ibm-cos-sdk-js) is blocking us as ibm-cos-sdk-js uses crypto-browserify which is not fips compliant. Do you have any timeline or approach to fix this issue?

For more info as why crypto-browserify is non fips compiant which consequently makes ibm-cos-sdk-js non fips compliant as well:
https://www.npmjs.com/package/crypto-browserify
The goal of this module is to reimplement node's crypto module, in pure javascript so that it can run in the browser.
Thanks

@arnabm28
Copy link

We have an internal ticket for this issue.

@linchiah
Copy link

@arnabm28 Hi, just want to follow up on this issue. Has it been addressed? Thanks.

@arnabm28
Copy link

Hi,

This is part of our backlog item.
Unfortunately this is currently not part of our current roadmap and release. So this continues to be part of the backlog items.

Thanks.

@remansour
Copy link

@arnabm28 We (IBM Cloud Console) have 12 UI microservices importing your package and it is now being flagged by Prisma Cloud (Twistlock) as Configuration issues that we need to remediate.

The IBM Cloud Policy requires every service to be using Prisma Cloud for scanning in the Production and non-production environments. Having these reported as findings will cause additional compliance complications and failures.

Can you provide an ETA on when this will be resolved?

@toeikmei
Copy link
Member

toeikmei commented Nov 6, 2023

@arnabm28 additionally the subdependency browserify-sign of crypto-browserify is now flagged to contain a security vulnerability with the severity high: GHSA-x9w5-v3q2-3rhw

Since crypto-browserify is not maintained anymore I guess you need to replace the whole module. As @remansour asked is there an ETA?

@IBMalok
Copy link
Contributor

IBMalok commented Nov 6, 2023

@toeikmei regarding- vulnerability GHSA-x9w5-v3q2-3rhw
The browserify-sign dependency package is always downloaded to the latest version(in this case - 4.2.2) because we don’t specify any particular versions for the browserify-sign. Thus, there’s no fix needed.

We are looking for an alternative to crypto-browserify and we are not in a position to provide an ETA at this time.

@remansour
Copy link

@IBMalok Can you give an indication on the progress on this issue?

@IBMalok
Copy link
Contributor

IBMalok commented Feb 26, 2024

@remansour
A quick update: The team is addressing the issue and making the necessary changes to fix it. Most likely, we will have deliveries by the middle of Q2.

@IBMalok
Copy link
Contributor

IBMalok commented Apr 29, 2024

@HMhamedminaee @linchiah @toeikmei @remansour
Provided the fix in 1.13.4, please verify and close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants