Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shift Block UI to use a Notebook style of presentation #5259

Merged
merged 1 commit into from Jul 27, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Jul 27, 2020

this also adds a StatusStripe widget that displays the CWD

Fixes #5258

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

this also adds a StatusStripe widget that displays the CWD

Fixes kubernetes-sigs#5258
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #5259 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5259   +/-   ##
=======================================
  Coverage   59.26%   59.26%           
=======================================
  Files          78       78           
  Lines        2526     2526           
  Branches      627      627           
=======================================
  Hits         1497     1497           
  Misses        797      797           
  Partials      232      232           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 59a9213...f5deab1. Read the comment docs.

@starpit starpit merged commit dc0ee4b into kubernetes-sigs:master Jul 27, 2020
@starpit starpit deleted the inny branch July 27, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: should Block UI be closer to a Notebook style of presentation?
1 participant