Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-client-common): tab completion UI does not render … #5308

Merged
merged 1 commit into from Aug 4, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 4, 2020

…on separate line from input

Fixes #5307

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #5308 into master will increase coverage by 0.29%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5308      +/-   ##
==========================================
+ Coverage   59.45%   59.74%   +0.29%     
==========================================
  Files          78       78              
  Lines        2538     2539       +1     
  Branches      627      627              
==========================================
+ Hits         1509     1517       +8     
+ Misses        792      788       -4     
+ Partials      237      234       -3     
Impacted Files Coverage Δ
packages/core/src/repl/types.ts 100.00% <ø> (ø)
packages/core/src/repl/exec.ts 75.13% <96.55%> (+4.48%) ⬆️
packages/core/src/core/userdata.ts 63.88% <0.00%> (-4.17%) ⬇️
packages/core/src/repl/enforce-usage.ts 60.57% <0.00%> (ø)
packages/core/src/repl/tab-completion.ts 73.33% <0.00%> (ø)
packages/core/src/models/tab-state.ts 57.40% <0.00%> (+1.85%) ⬆️
packages/core/src/models/RadioTable.ts 47.36% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1037f...1460ee6. Read the comment docs.

@starpit starpit merged commit 61b169b into kubernetes-sigs:master Aug 4, 2020
@starpit starpit deleted the fix-5307 branch August 4, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tab completion does not render quite right
1 participant