feat(plugins/plugin-ibmcloud): initial CodeEngine support #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5309 +/- ##
=======================================
Coverage 59.74% 59.74%
=======================================
Files 78 78
Lines 2539 2539
Branches 627 627
=======================================
Hits 1517 1517
Misses 788 788
Partials 234 234
Continue to review full report at Codecov.
|
myan9
commented
Aug 5, 2020
| listPodsAndExpectOne('nginx', ns) | ||
| listPodsAndExpectOne('nginx', ns, `--kubeconfig ${initialKubeConfig}`) | ||
| getPodInSidecar('nginx', ns, `--kubeconfig ${initialKubeConfig}`) |
There was a problem hiding this comment.
testing get --kubeconfig table, sidecar header, and summary tab
myan9
commented
Aug 5, 2020
| } | ||
| } | ||
| }).run() | ||
|
|
There was a problem hiding this comment.
test a large duration table auto-gridify, and switch to list view testing the cells
myan9
commented
Aug 5, 2020
| attributes: [{ value: 'foo' }, { value: '21000' }] | ||
| } | ||
| ] | ||
| }) |
There was a problem hiding this comment.
a duration table used for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5302
Fixes #5303
Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs