Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: s3 plugin, and vfs #5320

Merged
merged 1 commit into from Aug 9, 2020
Merged

feat: s3 plugin, and vfs #5320

merged 1 commit into from Aug 9, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 8, 2020

This covers most of the examples in the issue. It doesn't cover every possible use case, yet.

Providers supported:

  1. local minio
  2. ibm cloud object storage

TODO: AWS and Azure storage?
TODO: other use cases, e.g. cat file > /s3/bucket1/foo

Fixes #5319

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 8, 2020

Codecov Report

Merging #5320 into master will decrease coverage by 0.72%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5320      +/-   ##
==========================================
- Coverage   59.74%   59.02%   -0.73%     
==========================================
  Files          78       78              
  Lines        2539     2543       +4     
  Branches      627      628       +1     
==========================================
- Hits         1517     1501      -16     
- Misses        788      797       +9     
- Partials      234      245      +11     
Impacted Files Coverage 螖
packages/core/src/webapp/tab.ts 73.91% <50.00%> (-6.09%) 猬囷笍
packages/core/src/repl/exec.ts 75.80% <100.00%> (+0.67%) 猬嗭笍
packages/core/src/core/command-tree.ts 61.60% <0.00%> (-4.47%) 猬囷笍
packages/core/src/core/usage-error.ts 46.13% <0.00%> (-2.49%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 407855a...97fea04. Read the comment docs.

This covers most of the examples in the issue. It doesn't cover every possible use case, yet.

Providers supported:
1) local minio
2) ibm cloud object storage

TODO: AWS and Azure storage?
TODO: other use cases, e.g. cat file > /s3/bucket1/foo

Fixes kubernetes-sigs#5319
@starpit
Copy link
Contributor Author

starpit commented Aug 9, 2020

for future reference: the s3 impl uses the s3 API, so there is nothing minio or ibmcloud specific about the vfs layer. however, the credentials providers will need to be implemented for other cloud providers. see plugin-s3/src/providers

@starpit starpit merged commit 970ba6e into kubernetes-sigs:master Aug 9, 2020
@starpit starpit deleted the s3 branch August 10, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add support for interacting with s3
1 participant