Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-client-common): long input lines should line wrap #5339

Merged
merged 1 commit into from Aug 11, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 11, 2020

this PR only fixes Processing and Completed blocks. we will still have a problem with line wrapping of active inputs

Fixes #5338

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

this PR only fixes Processing and Completed blocks. we will still have a problem with line wrapping of active inputs

Fixes kubernetes-sigs#5338
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #5339 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5339   +/-   ##
=======================================
  Coverage   59.02%   59.02%           
=======================================
  Files          78       78           
  Lines        2543     2543           
  Branches      628      628           
=======================================
  Hits         1501     1501           
  Misses        797      797           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3539acf...21b5ae4. Read the comment docs.

@starpit starpit merged commit 8804bb1 into kubernetes-sigs:master Aug 11, 2020
@starpit starpit deleted the fix-5338 branch August 11, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long input lines are cropped
1 participant