Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-kubectl): add traffic light colors for OOMKilled a… #5346

Merged
merged 1 commit into from Aug 13, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 12, 2020

…nd UnexpectedAdmissionError

Fixes #5345

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5346 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5346      +/-   ##
==========================================
- Coverage   59.15%   59.04%   -0.12%     
==========================================
  Files          78       78              
  Lines        2544     2544              
  Branches      629      629              
==========================================
- Hits         1505     1502       -3     
- Misses        794      797       +3     
  Partials      245      245              
Impacted Files Coverage Δ
packages/core/src/core/userdata.ts 63.88% <0.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2fb41...975a191. Read the comment docs.

@starpit starpit merged commit 4262409 into kubernetes-sigs:master Aug 13, 2020
@starpit starpit deleted the fix-5345 branch August 13, 2020 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two missing pod status colors: OOMKilled and UnexpectedAdmissionError
1 participant