Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-kubectl): Fail should be TrafficLight.Red and Succ… #5352

Merged
merged 1 commit into from Aug 13, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 13, 2020

…eeded should be TrafficLight.Green

Fixes #5351

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5352 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5352   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files          78       78           
  Lines        2544     2544           
  Branches      629      629           
=======================================
  Hits         1502     1502           
  Misses        797      797           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c929f5e...1ea923c. Read the comment docs.

@starpit starpit merged commit 54737b6 into kubernetes-sigs:master Aug 13, 2020
@starpit starpit deleted the fix-5351 branch August 13, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail should be TrafficLight.Red and Succeeded should be TrafficLight.Green
1 participant