Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-bash-like): ls should measure gridTemplateColumns more intelligently #5354

Merged
merged 1 commit into from Aug 13, 2020

Conversation

myan9
Copy link
Contributor

@myan9 myan9 commented Aug 13, 2020

For a typical ls command, the following screenshots show the effect of measurement

Before the change:
Screen Shot 2020-08-13 at 2 25 35 PM

After the change:
Screen Shot 2020-08-13 at 2 25 59 PM
Fixes #5353

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@myan9 myan9 requested a review from starpit as a code owner August 13, 2020 18:30
@myan9 myan9 changed the title fix(plugins/plugin-bash-like): ls should measure gridTemplateColumns … fix(plugins/plugin-bash-like): ls should measure gridTemplateColumns more intelligently Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5354 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5354   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files          78       78           
  Lines        2544     2544           
  Branches      629      629           
=======================================
  Hits         1502     1502           
  Misses        797      797           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c929f5e...c143c08. Read the comment docs.

Copy link
Contributor

@starpit starpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@starpit starpit merged commit 0b06e60 into kubernetes-sigs:master Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls should measure gridTemplateColumns more intelligently
2 participants