Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-client-common): reverse-i-search incorrectly chang… #5404

Merged
merged 1 commit into from Aug 19, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 19, 2020

…es match as i type

Fixes #5403

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #5404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5404   +/-   ##
=======================================
  Coverage   59.08%   59.08%           
=======================================
  Files          78       78           
  Lines        2544     2544           
  Branches      629      629           
=======================================
  Hits         1503     1503           
  Misses        796      796           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82989ab...e71b109. Read the comment docs.

@starpit starpit merged commit 135d429 into kubernetes-sigs:master Aug 19, 2020
@starpit starpit deleted the fix-5403 branch August 19, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reverse-i-search acts oddly
1 participant