Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out Scripts are Optimized in the Importing Task #474

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

lnxpy
Copy link
Contributor

@lnxpy lnxpy commented Sep 30, 2020

isort module observed on the outer scripts. So that neither search/*.py, lib/*.py, datasets/*.py, and utils/*.py have been changed which means that the schema2search_space.py file is still like the usual.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #474 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #474      +/-   ##
==========================================
- Coverage   84.12%   84.10%   -0.03%     
==========================================
  Files         285      285              
  Lines       14347    14341       -6     
==========================================
- Hits        12070    12062       -8     
- Misses       2277     2279       +2     
Impacted Files Coverage Δ
lale/docstrings.py 98.86% <ø> (ø)
lale/expressions.py 70.76% <100.00%> (ø)
lale/grammar.py 80.61% <100.00%> (-0.20%) ⬇️
lale/helpers.py 81.32% <100.00%> (-0.17%) ⬇️
lale/json_operator.py 90.43% <100.00%> (ø)
lale/operator_wrapper.py 100.00% <100.00%> (ø)
lale/operators.py 86.81% <100.00%> (-0.13%) ⬇️
lale/pretty_print.py 98.63% <100.00%> (ø)
lale/schema2enums.py 74.07% <100.00%> (ø)
lale/schema_ranges.py 64.58% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38297eb...538d597. Read the comment docs.

@lnxpy lnxpy marked this pull request as ready for review October 2, 2020 10:16
@hirzel
Copy link
Member

hirzel commented Oct 2, 2020

Thanks, happy to see that this version passes Travis. Also, I read through the code changes, and they look good to me. Could you please sign a DCO as outlined in contributing.md? You can email it to me: hirzel at us dot ibm dot com.

@lnxpy
Copy link
Contributor Author

lnxpy commented Oct 2, 2020

That's my pleasure. Should I send the DCO doc back to you? Is it enough or any other significant required?

@hirzel
Copy link
Member

hirzel commented Oct 2, 2020

Yes, could you please email the signed DCO back to me?

@lnxpy
Copy link
Contributor Author

lnxpy commented Oct 2, 2020

Everything is done. Special thanks to you for checking out the PRs. Really appreciate your attention. I really amazed by the name of the project; just because my native language is Persian. ❤️✌️

@hirzel hirzel merged commit 7b7e043 into IBM:master Oct 2, 2020
@lnxpy
Copy link
Contributor Author

lnxpy commented Oct 4, 2020

Hey dear @hirzel,
Do you mind if I ask you to first, review this PR and finally, add the "hacktoberfest" label to this pull request?
Thanks.

@shinnar shinnar mentioned this pull request Oct 5, 2020
Copy link
Member

@hirzel hirzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes sort import statements in Python files that are directly in the main lale directory. There are no changes to the code outside of those import statements. The Travis tests succeeded.

@lnxpy
Copy link
Contributor Author

lnxpy commented Oct 5, 2020

Thanks. I'll contribute to the main algorithm and add new features soon.

@shinnar
Copy link
Member

shinnar commented Oct 5, 2020

thanks for contributing this and getting this started! Continuing on this work, #481 resolved the issue with schema2search_space.py, ran isort on everything, and added isort to our new pre-commit setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants