New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out Scripts are Optimized in the Importing Task #474
Conversation
Codecov Report
@@ Coverage Diff @@
## master #474 +/- ##
==========================================
- Coverage 84.12% 84.10% -0.03%
==========================================
Files 285 285
Lines 14347 14341 -6
==========================================
- Hits 12070 12062 -8
- Misses 2277 2279 +2
Continue to review full report at Codecov.
|
Thanks, happy to see that this version passes Travis. Also, I read through the code changes, and they look good to me. Could you please sign a DCO as outlined in contributing.md? You can email it to me: hirzel at us dot ibm dot com. |
That's my pleasure. Should I send the DCO doc back to you? Is it enough or any other significant required? |
Yes, could you please email the signed DCO back to me? |
Everything is done. Special thanks to you for checking out the PRs. Really appreciate your attention. I really amazed by the name of the project; just because my native language is Persian. ❤️✌️ |
Hey dear @hirzel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes sort import statements in Python files that are directly in the main lale
directory. There are no changes to the code outside of those import statements. The Travis tests succeeded.
Thanks. I'll contribute to the main algorithm and add new features soon. |
thanks for contributing this and getting this started! Continuing on this work, #481 resolved the issue with schema2search_space.py, ran isort on everything, and added |
isort
module observed on the outer scripts. So that neithersearch/*.py
,lib/*.py
,datasets/*.py
, andutils/*.py
have been changed which means that theschema2search_space.py
file is still like the usual.