Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dataclasses to reduce the complexity of the config and environment packages #84

Closed
dvaccarosenna opened this issue May 11, 2021 · 0 comments · Fixed by #90
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dvaccarosenna
Copy link
Member

Several classes in lmctl.config and lmctl.environment are just data objects for configuration, parsed from a YAML file. A lot of code has been written to parse the YAML content, to a dictionary, then the final classes.

These packages may be greatly simplified by using dataclasses. This could be either native Python dataclasses or by using a validation library such as Pydantic.

By doing so, changes and maintenance of these packages would be greatly reduced as additional parsing logic would not be required each time there is a change (e.g. for future Zen auth support and Site Planner support).

@dvaccarosenna dvaccarosenna added the enhancement New feature or request label May 11, 2021
@dvaccarosenna dvaccarosenna added this to the 3.1.0 milestone May 11, 2021
@dvaccarosenna dvaccarosenna self-assigned this May 11, 2021
@dvaccarosenna dvaccarosenna mentioned this issue Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant