You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several classes in lmctl.config and lmctl.environment are just data objects for configuration, parsed from a YAML file. A lot of code has been written to parse the YAML content, to a dictionary, then the final classes.
These packages may be greatly simplified by using dataclasses. This could be either native Python dataclasses or by using a validation library such as Pydantic.
By doing so, changes and maintenance of these packages would be greatly reduced as additional parsing logic would not be required each time there is a change (e.g. for future Zen auth support and Site Planner support).
The text was updated successfully, but these errors were encountered:
Several classes in
lmctl.config
andlmctl.environment
are just data objects for configuration, parsed from a YAML file. A lot of code has been written to parse the YAML content, to a dictionary, then the final classes.These packages may be greatly simplified by using dataclasses. This could be either native Python dataclasses or by using a validation library such as Pydantic.
By doing so, changes and maintenance of these packages would be greatly reduced as additional parsing logic would not be required each time there is a change (e.g. for future Zen auth support and Site Planner support).
The text was updated successfully, but these errors were encountered: