Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Button-less Option #39

Closed
manicslothpdx opened this issue Jul 30, 2021 · 9 comments · Fixed by #56
Closed

Add Button-less Option #39

manicslothpdx opened this issue Jul 30, 2021 · 9 comments · Fixed by #56
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@manicslothpdx
Copy link

Adding the option to have a button-less popup would be helpful for workflows that show multiple different messages to users in succession but that don't require user input. For example, when patching an application, it may make sense to show a progress bar popup, but when it's complete, instead of requiring the user to click the "Ok" button, the progress bar window would be killed and a "This patch is complete" popup would take its place.

@SMartorelli
Copy link
Member

SMartorelli commented Jul 30, 2021

Hi @manicslothpdx, thanks for your feedback.
I've a couple of questions for you:

  1. Do you think that a progress bar AV that at the end trigger the exit of the agent instead of showing the buttons could work? Since what you're trying to reproduce is still a background process I think that the progress bar is a good method to show it.
  2. Since the second pop-up should anyway be triggered by your script, there are any differences between the result you suggested and a progress bar pop-up with a "top_message" set to "This patch is complete" and the "Ok" button visible at the end of the progress?

@SMartorelli SMartorelli added the question Further information is requested label Jul 30, 2021
@manicslothpdx
Copy link
Author

Here are the three stages that we use:

ac1

ac2

ac3

@manicslothpdx
Copy link
Author

manicslothpdx commented Aug 2, 2021

For question 2, the "success" message that we show is too big to fit in the "top_message" field.

I don't think I understand question 1. Right now, when the progress bar is complete, there is a brief moment when there is an "Ok" button displayed. It is mostly a cosmetic issue because we kill the window process fast so that we can show the 3rd popup, but there is a moment when a user could still get confused and click the "Ok" button at the end of the progress bar. It would be "cleaner" if we didn't need to show a button at any point during the progress bar popup. We modified the app in Xcode on our own to do this for us so that we could test it, and our test users agreed that it was cleaner.

@SMartorelli
Copy link
Member

Hi @manicslothpdx with the first question I meant to ask you if a progress bar popup with the option to close it self automatically at the end of the process might be useful instead of it showing the buttons. We can add an additional customisation key to the progress bar accessory view (like "/auto_close"). Could this fit this feature request scope?

@manicslothpdx
Copy link
Author

In my personal opinion, in our workflow it would still look odd if a progress bar-style popup shows a button and then auto-dismisses. That's basically what we're doing now anyway with a "pkill IBM Notifier" command. It would just be nice to have the option to show no button. This is what our 2nd popup looks like for a few seconds before it is killed:

Screen Shot 2021-08-03 at 12 54 13 PM

@SMartorelli
Copy link
Member

Yes of course I mean it should auto dismiss and show no buttons.

@manicslothpdx
Copy link
Author

So, are you saying that if you add an "auto-close" parameter, it would also not show any button at the end of the progress bar popup? That might work. Would "auto-close" have the ability to set a timeout setting too, or would the existing timeout attribute also work?

@SMartorelli
Copy link
Member

I guess the background timeout in this case is not needed since the pop-up with the progress bar should automatically close at the end of the progress bar updates. Then the additional pop-up with the "This patch is complete" message should be anyway triggered by your script at the auto-exit of the progress bar one.

@SMartorelli
Copy link
Member

Will add a payload key for progress bar accessory view to allow the popup to automatically exit 0 at the end of the progress.

@SMartorelli SMartorelli added enhancement New feature or request and removed question Further information is requested labels Aug 13, 2021
@SMartorelli SMartorelli self-assigned this Aug 13, 2021
@SMartorelli SMartorelli added this to the Version 2.3.1 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants