Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize params names across methods, problems etc. #73

Open
sesevgen opened this issue Nov 8, 2018 · 2 comments
Open

Standardize params names across methods, problems etc. #73

sesevgen opened this issue Nov 8, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@sesevgen
Copy link
Collaborator

sesevgen commented Nov 8, 2018

There is inconsistent naming across params. For example, directories are sometimes called 'dir' and sometimes called 'folder'. We should perhaps decide on a unified set of standard names for source and target folders etc, and then change init and configs to reflect it.

@tkornuta-ibm
Copy link
Contributor

I totally agree, I already started that with CLEVR, Sort-of-CLEVR, MNIST and CIFAR10.

I used "data_folder", with default value set to "~/data/mnist" (in the case of MNIST;) )

Besides, along with the introduction of helpers that can operate directly on problems/models, we have made a decision that all problems/models should provide default values for all parameters, enabling to instantiate them without configuration file.

Please refer to:

self.params.add_default_params({'data_folder': '~/data/mnist',

@sesevgen Please keep that in mind now, probably I should create a separate issues for this...

@vmarois
Copy link
Contributor

vmarois commented Nov 8, 2018

Agree on this as well.
Alongside unifying the names used for the 'common' arguments, we should also make more explicit the several arguments that a Problem / Model class expects. This is indicated in #34 🙂

@vmarois vmarois added the enhancement New feature or request label Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants