fix: skips warning for non-ref response schemas when not content is n…

…ot json
IBM · Jun 18, 2019 · 624d41a · 624d41a
1 parent 7219f2b
commit 624d41a
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 1 deletion.
diff --git a/src/plugins/validation/2and3/semantic-validators/responses.js b/src/plugins/validation/2and3/semantic-validators/responses.js
@@ -20,7 +20,10 @@ module.exports.validate = function({ jsSpec, isOAS3 }, config) {
         if (isOAS3) {
           each(response.content, (mediaType, mediaTypeKey) => {
             const hasInlineSchema = mediaType.schema && !mediaType.schema.$ref;
-            if (hasInlineSchema) {
+            if (
+              hasInlineSchema &&
+              mediaTypeKey.startsWith('application/json')
+            ) {
               const checkStatus = config.inline_response_schema;
               if (checkStatus !== 'off') {
                 result[checkStatus].push({

diff --git a/test/plugins/validation/2and3/responses.js b/test/plugins/validation/2and3/responses.js
@@ -268,6 +268,43 @@ describe('validation plugin - semantic - responses', function() {
         );
         expect(res.errors.length).toEqual(0);
       });
+
+      it('should not complain about non-json response that defines an inline schema', function() {
+        const config = {
+          responses: {
+            no_response_codes: 'error',
+            no_success_response_codes: 'warning'
+          }
+        };
+
+        const spec = {
+          paths: {
+            '/pets': {
+              get: {
+                summary: 'this is a summary',
+                operationId: 'operationId',
+                responses: {
+                  '400': {
+                    description: 'bad request',
+                    content: {
+                      'plain/text': {
+                        schema: {
+                          type: 'string',
+                          format: 'binary'
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        };
+
+        const res = validate({ jsSpec: spec }, config);
+        expect(res.warnings.length).toEqual(0);
+        expect(res.errors.length).toEqual(0);
+      });
     });
   });
 });