Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent crash when parameters is illegally not an array #104

Merged
merged 1 commit into from
Sep 9, 2019

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Aug 27, 2019

This file assumes parameters will be an array and calls the map method on it. This prevents it from doing so if parameters is not an array.

Resolves #101

@dpopp07 dpopp07 requested a review from mkistler August 27, 2019 20:02
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@8b81a7d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #104   +/-   ##
=========================================
  Coverage          ?   92.04%           
=========================================
  Files             ?       52           
  Lines             ?     1873           
  Branches          ?        0           
=========================================
  Hits              ?     1724           
  Misses            ?      149           
  Partials          ?        0
Impacted Files Coverage Δ
...gins/validation/2and3/semantic-validators/paths.js 85.45% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b81a7d...d2b506c. Read the comment docs.

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@dpopp07 dpopp07 merged commit 5d8a429 into master Sep 9, 2019
@dpopp07 dpopp07 deleted the non-array-parameters branch September 9, 2019 15:38
dpopp07 pushed a commit that referenced this pull request Sep 9, 2019
## [0.13.6](v0.13.5...v0.13.6) (2019-09-09)

### Bug Fixes

* prevent crash when `parameters` is illegally not an array ([#104](#104)) ([5d8a429](5d8a429))
@dpopp07
Copy link
Member Author

dpopp07 commented Sep 9, 2019

🎉 This PR is included in version 0.13.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants