Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 170 tag checks refactor #171

Merged
merged 2 commits into from
Jun 23, 2020

Conversation

jormaechea
Copy link
Contributor

Breaking change

  • The current unused_tag now checks for tags defined in tags section but not used in any operation.
  • The new undefined_tag checks for tags used in operations but not defined in tags section (previous unused_tag behaviour)

Discussed in #170

@dpopp07 dpopp07 self-requested a review June 22, 2020 14:15
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great. Thanks for doing this. I will merge and release soon

@dpopp07 dpopp07 merged commit 95a4308 into IBM:master Jun 23, 2020
dpopp07 pushed a commit that referenced this pull request Jun 23, 2020
# [0.28.0](v0.27.1...v0.28.0) (2020-06-23)

### Features

* rule `unused_tag` renamed to `undefined_tag` ([#171](#171)) ([95a4308](95a4308))
@dpopp07
Copy link
Member

dpopp07 commented Jun 23, 2020

🎉 This PR is included in version 0.28.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants