fix: properly handle circular regressions to prevent call stack exceptions #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions A regression was recently introduced to the validator in the circular references utility that prevented such references from being caught and sanitized. This resulted in "call stack exceeded" expections for certain patterns using circular references. The regression came in the form of checking for only "plain" objects, rather than all "objects" (which include arrays). This happened in a recent community PR and I didn't realize the consequences when I reviewed and merged. I went back and double checked every instance of this change in that PR and believe this is the only one that is problematic. I fixed it and added a new test case that would've caught this regression had it been there.
barrett-schonefeld
approved these changes
Feb 26, 2021
dpopp07
pushed a commit
that referenced
this pull request
Mar 1, 2021
## [0.34.4](v0.34.3...v0.34.4) (2021-03-01) ### Bug Fixes * properly handle circular regressions to prevent call stack exceptions ([#253](#253)) ([3696487](3696487))
|
🎉 This PR is included in version 0.34.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was recently introduced to the validator in the circular references
utility that prevented such references from being caught and sanitized. This resulted
in "call stack exceeded" exceptions for certain patterns using circular references.
The regression came in the form of checking for only "plain" objects, rather than
all "objects" (which include arrays). This happened in a recent community PR and I
didn't realize the consequences when I reviewed and merged. I went back and double
checked every instance of this change in that PR and believe this is the only one
that is problematic. I fixed it and added a new test case that would've caught this
regression had it been there.
Resolves #251