-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate x-sdk-operations
extension
#290
Conversation
Codecov Report
@@ Coverage Diff @@
## main #290 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 73 73
Lines 2376 2377 +1
Branches 605 605
=======================================
+ Hits 2186 2187 +1
Misses 157 157
Partials 33 33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the doc changes are a bit messed up.
And I had an idea about using regex replace to update the paths.
2b3e44a
to
3d11414
Compare
Purpose: - Validate that the x-sdk-operations extension is used correctly. Changes: - Load the absolute path to the JSON Schema into static assets, so when the `ibm:oas` ruleset is extended, still able to find the JSON Schema Tests: - Ensure `ibm-sdk-operations` rule catches errors Docs: - Document the `ibm-sdk-operations` rule
3d11414
to
11ddb36
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
# [0.46.0](v0.45.0...v0.46.0) (2021-05-05) ### Features * validate `x-sdk-operations` extension ([#290](#290)) ([019c06f](019c06f))
🎉 This PR is included in version 0.46.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description:
schema
function has the same problem we observed (in Spectral5.8.1
and below) in theoas3-schema
rule where only one error is returned at a time. We will want to follow up on this implementation by raising this issue to Spectral and fixing theschema
function.Purpose:
Changes:
ibm:oas
ruleset is extended, still able to find the JSON Schema./schema
in.defaultsforspectral.yaml
with their absolute path using regex replaceTests:
ibm-sdk-operations
rule catches errorsDocs:
ibm-sdk-operations
rule