fix: don't crash when parameter is missing required "in" property #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, we assume that parameters will have all required properties. This results in the code crashing ungracefully if the "in" property is missing. This PR corrects that. Missing "in" properties are already caught by spectral if there aren't other issues with the property.
Codecov Report
@@ Coverage Diff @@
## main #308 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 73 73
Lines 2377 2377
Branches 605 606 +1
=======================================
Hits 2187 2187
Misses 157 157
Partials 33 33
Continue to review full report at Codecov.
|
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Jul 14, 2021
## [0.46.2](v0.46.1...v0.46.2) (2021-07-14) ### Bug Fixes * don't crash when parameter is missing required "in" property ([#308](#308)) ([8bf7df5](8bf7df5))
|
🎉 This PR is included in version 0.46.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we assume that parameters will have all required properties. This results
in the code crashing ungracefully if the "in" property is missing. This PR corrects
that. Missing "in" properties are already caught by spectral if there aren't other
issues with the property.
Resolves #307