-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove npm_force_resolutions from pre-install step to fix user package install #337
Conversation
Codecov Report
@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 91.90% 91.98% +0.07%
==========================================
Files 73 74 +1
Lines 2348 2370 +22
Branches 598 600 +2
==========================================
+ Hits 2158 2180 +22
Misses 157 157
Partials 33 33
Continue to review full report at Codecov.
|
78e05a1
to
a5e700c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
## [0.51.3](v0.51.2...v0.51.3) (2021-10-11) ### Bug Fixes * remove npm_force_resolutions from pre-install step to fix user package install ([#337](#337)) ([0a02977](0a02977))
🎉 This PR is included in version 0.51.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Removes
npx npm-force-resolutions
from preinstall step and dependencies so the user package can be installed without issue. However this means thenpm-force-resolutions
dev package must be run locally usingnpm run force-deps
before new PR changes are made