Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove npm_force_resolutions from pre-install step to fix user package install #337

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

rmkeezer
Copy link
Contributor

@rmkeezer rmkeezer commented Oct 11, 2021

Removes npx npm-force-resolutions from preinstall step and dependencies so the user package can be installed without issue. However this means the npm-force-resolutions dev package must be run locally using npm run force-deps before new PR changes are made

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #337 (08d1366) into main (cdb0e47) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 08d1366 differs from pull request most recent head a5e700c. Consider uploading reports for the commit a5e700c to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   91.90%   91.98%   +0.07%     
==========================================
  Files          73       74       +1     
  Lines        2348     2370      +22     
  Branches      598      600       +2     
==========================================
+ Hits         2158     2180      +22     
  Misses        157      157              
  Partials       33       33              
Impacted Files Coverage Δ
src/cli-validator/utils/circular-references-ibm.js 96.72% <100.00%> (+0.29%) ⬆️
src/lib/index.js 90.00% <100.00%> (ø)
...t-utils/get-message-and-path-from-captured-text.js 100.00% <100.00%> (ø)
test/test-utils/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 925fd7e...a5e700c. Read the comment docs.

@rmkeezer rmkeezer force-pushed the rmk/fix_npm_force_resolutions branch from 78e05a1 to a5e700c Compare October 11, 2021 16:55
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@rmkeezer rmkeezer merged commit 0a02977 into main Oct 11, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Oct 11, 2021
## [0.51.3](v0.51.2...v0.51.3) (2021-10-11)

### Bug Fixes

* remove npm_force_resolutions from pre-install step to fix user package install ([#337](#337)) ([0a02977](0a02977))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.51.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@padamstx padamstx deleted the rmk/fix_npm_force_resolutions branch March 9, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants