Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli command that will only print errors #68

Merged
merged 9 commits into from
Jun 24, 2019
Merged

feat: cli command that will only print errors #68

merged 9 commits into from
Jun 24, 2019

Conversation

SamerJaser96
Copy link
Contributor

Users can now use '-e' or '--only_errors' cli commands when using the validator to only see errors instead of the list of warnings and errors

dpopp07
dpopp07 requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, but there a couple changes to make.

Also, will you add a couple test cases? The optionHandling.js file is where they would go. Test this for printJson as well

src/.defaultsForValidator.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/utils/printResults.js Outdated Show resolved Hide resolved
dpopp07
dpopp07 requested changes Jun 21, 2019
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some changes needed. Make sure you're going through your changes before you commit to ensure you aren't accidentally pushing old console statements, etc

src/.defaultsForValidator.js Outdated Show resolved Hide resolved
src/cli-validator/index.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/utils/printJsonResults.js Outdated Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Outdated Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Outdated Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 21, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (master@8eecc2d). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage          ?   91.75%           
=========================================
  Files             ?       51           
  Lines             ?     1856           
  Branches          ?        0           
=========================================
  Hits              ?     1703           
  Misses            ?      153           
  Partials          ?        0
Impacted Files Coverage Δ
src/cli-validator/utils/printResults.js 100% <100%> (ø)
src/cli-validator/runValidator.js 93.38% <100%> (ø)
src/cli-validator/utils/printJsonResults.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eecc2d...1f1f469. Read the comment docs.

dpopp07
dpopp07 requested changes Jun 21, 2019
View reviewed changes
src/cli-validator/utils/printJsonResults.js Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/index.js Outdated Show resolved Hide resolved
dpopp07
dpopp07 requested changes Jun 24, 2019
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost ready, just some style changes left

src/cli-validator/index.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Outdated Show resolved Hide resolved
src/cli-validator/runValidator.js Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Outdated Show resolved Hide resolved
test/cli-validator/tests/optionHandling.js Outdated Show resolved Hide resolved
dpopp07
dpopp07 approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dpopp07 dpopp07 merged commit a338bf0 into master Jun 24, 2019
@dpopp07 dpopp07 deleted the config-errors branch June 24, 2019 19:56
dpopp07 pushed a commit that referenced this pull request Jun 24, 2019
@semantic-release-bot
chore(release): 0.12.0 [skip ci]
aed7514 
# [0.12.0](v0.11.2...v0.12.0) (2019-06-24)

### Features

* new cli option, `--errors_only`, for printing only the errors ([#68](#68)) ([a338bf0](a338bf0))
@dpopp07
Copy link
Member

dpopp07 commented Jun 24, 2019

🎉 This PR is included in version 0.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpopp07 dpopp07 dpopp07 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamerJaser96 @dpopp07