Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "print version" option #9

Merged
merged 4 commits into from
Nov 19, 2018
Merged

Add a "print version" option #9

merged 4 commits into from
Nov 19, 2018

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Nov 15, 2018

This came up while looking at an issue with Allen - there was no obvious way to see which version he had installed locally. Since most CLI tools use the -v option to print the version, I decided to add this.

There was previously a -v arg for printing validator file names but that was a debug tool I made for myself and I can't imagine any users would use that, plus we are still in 0.x so we can make breaking changes 馃槒

In this PR...

  • The -v option is updated to print the version
  • The print validator version is changed to -p
  • The logic for turning off coloring is simplified with a ternary operator
  • The README is updated with new option and also correct some outdated statements (the npm --save option is now deprecated)
  • The appropriate option handler test is updated

@SirSpidey
Copy link
Member

oh sure. blame me.

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 馃憤

@dpopp07 dpopp07 merged commit b4d7fce into master Nov 19, 2018
@dpopp07 dpopp07 deleted the print-version-option branch November 19, 2018 14:31
dpopp07 pushed a commit that referenced this pull request Jul 23, 2019
## [0.13.2](v0.13.1...v0.13.2) (2019-07-23)

### Bug Fixes

* filter out [#9](#9 chars from input ([#89](#89)) ([0b154d4](0b154d4))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants