Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Resource Controller): update service after recent API changes #112

Merged
merged 8 commits into from
Apr 21, 2021

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Apr 15, 2021

PR summary

This PR updates the Resource Controller service and the integration tests.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pyrooka pyrooka requested a review from padamstx April 15, 2021 18:59
@pyrooka pyrooka marked this pull request as draft April 16, 2021 14:49
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one really minor thing... need to remove one display label for a delete operation. I'll approve now to avoid a re-review.

@pyrooka pyrooka marked this pull request as ready for review April 20, 2021 18:09
@padamstx padamstx merged commit cd579d1 into main Apr 21, 2021
@padamstx padamstx deleted the update-rc branch April 21, 2021 19:27
ibm-devx-sdk pushed a commit that referenced this pull request Apr 21, 2021
## [0.18.9](v0.18.8...v0.18.9) (2021-04-21)

### Bug Fixes

* **Resource Controller:** update service after recent API changes ([#112](#112)) ([cd579d1](cd579d1))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.18.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants