Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(IAM Access Groups): update service after service url adjustment #169

Merged
merged 4 commits into from
Dec 3, 2021
Merged

fix(IAM Access Groups): update service after service url adjustment #169

merged 4 commits into from
Dec 3, 2021

Conversation

narinder-kaur
Copy link
Member

@narinder-kaur narinder-kaur commented Nov 23, 2021 •
edited

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR removes the version in the ag api global url and move it to the path.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2021 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ padamstx
❌ Narinder

Narinder seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@padamstx padamstx self-requested a review November 23, 2021 19:19
@padamstx padamstx self-assigned this Nov 23, 2021
@padamstx padamstx changed the title fix(access-group-service): moved version out of url path fix(IAM Access Groups): moved version out of url path Nov 23, 2021
padamstx
padamstx reviewed Nov 23, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

padamstx
padamstx approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title fix(IAM Access Groups): moved version out of url path fix(IAM Access Groups): update service after service url adjustment Dec 2, 2021
@padamstx padamstx merged commit 219fb73 into main Dec 3, 2021
@padamstx padamstx deleted the access-groups-url-fix branch December 3, 2021 14:26
ibm-devx-sdk pushed a commit that referenced this pull request Dec 3, 2021
@semantic-release-bot
chore(release): 0.22.6 release notes [skip ci]
b9f72e9 
## [0.22.6](v0.22.5...v0.22.6) (2021-12-03)

### Bug Fixes

* **IAM Access Groups:** update service after service url adjustment ([#169](#169)) ([219fb73](219fb73))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.22.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@narinder-kaur narinder-kaur mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@narinder-kaur @CLAassistant @ibm-devx-sdk @padamstx