Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity Tracker): Added support for event streams targets in Atracker v2 API #206

Merged
merged 4 commits into from
Sep 15, 2022

Conversation

veenanr
Copy link
Contributor

@veenanr veenanr commented Sep 14, 2022

Signed-off-by: Veena Rao veenar@us.ibm.com

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few changes needed in the integration tests to allow the tests to exercise all three target types independently.

atrackerv2/atracker_v2_integration_test.go Outdated Show resolved Hide resolved
atrackerv2/atracker_v2_integration_test.go Outdated Show resolved Hide resolved
veenanr and others added 4 commits September 15, 2022 10:35
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Co-authored-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Signed-off-by: Veena Rao <veenar@us.ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Could you please post a screenshot of a successful run of the atrackerv2 integration tests and examples for atrackerv2?
(e.g. cd atrackerv2, go test -tags=integration,examples)? Thanks!

Once we have those results, I'll go ahead and merge.

@veenanr
Copy link
Contributor Author

veenanr commented Sep 15, 2022

image

@padamstx
Copy link
Member

In the screen shot, it looks like you ran only unit and integration tests but not examples. You can use -tags=integration,examples to run unit tests, int tests and examples all at once.

@veenanr
Copy link
Contributor Author

veenanr commented Sep 15, 2022

testRun.txt

@padamstx padamstx merged commit cc063b3 into main Sep 15, 2022
@padamstx padamstx deleted the regen-atracker-09142022 branch September 15, 2022 16:09
ibm-devx-sdk pushed a commit that referenced this pull request Sep 15, 2022
## [0.28.3](v0.28.2...v0.28.3) (2022-09-15)

### Bug Fixes

* **Activity Tracker:** add support for event streams targets in Atracker v2 API ([#206](#206)) ([cc063b3](cc063b3))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.28.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants