Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): add support for v2/policies API from IAM #220

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Nov 16, 2022

PR summary

Code to support new v2/policies API has been introduced. The new v2/policies API will have new JSON fields and existing v1/fields have been changed.

v1/policies API will continue to be supported.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR's are merged for staging and production docs:
Staging: https://github.ibm.com/cloud-api-docs/iam-access-management/pull/139
Production: https://github.ibm.com/cloud-api-docs/iam-access-management/pull/140

Current vs new behavior

Current behavior will remain same (v1 will continue to be supported). New behavior is v2/policies support which allows for time based restriction policies using new rule field (an integration test has been added of this example).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

See:
Issue: https://github.ibm.com/IAM/AM-issues/issues/925
TRI: https://github.ibm.com/IAM/architecture/blob/master/TRIDocs/Access-Management/Smart-Policies/smart_policies.md

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx
Copy link
Member

New changes look good. I'll just wait until the PR build is finished...

@padamstx padamstx merged commit 23d81fd into IBM:main Nov 17, 2022
ibm-devx-sdk pushed a commit that referenced this pull request Nov 17, 2022
# [0.30.0](v0.29.5...v0.30.0) (2022-11-17)

### Features

* **IAM Policy Management:** add support for v2/policies API from IAM ([#220](#220)) ([23d81fd](23d81fd))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

adya1303 pushed a commit that referenced this pull request Dec 6, 2022
…#220)

* feat(IAM Policy Management): add support for v2/policies API from IAM
* new generated file based on API definition change, description added

Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
adya1303 pushed a commit that referenced this pull request Dec 6, 2022
# [0.30.0](v0.29.5...v0.30.0) (2022-11-17)

### Features

* **IAM Policy Management:** add support for v2/policies API from IAM ([#220](#220)) ([23d81fd](23d81fd))

Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants