feat(IAM Identity): adding userExpm list and token lifetime #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
approved these changes
Nov 22, 2022
iamidentityv1/iam_identity_v1.go
Outdated
| } | ||
|
|
||
| builder := core.NewRequestBuilder(core.POST) | ||
| builder = builder.WithContext(ctx) | ||
| builder.EnableGzipCompression = iamIdentity.GetEnableGzipCompression() | ||
| _, err = builder.ResolveRequestURL(iamIdentity.Service.Options.URL, `/v1/activity/accounts/{account_id}/report`, pathParamsMap) | ||
| _, err = builder.ResolveRequestURL(iamIdentity.Service.Options.URL, `/v1/activity/accounts/{account-id}/report`, pathParamsMap) |
There was a problem hiding this comment.
looks like this path param was changed from using snake-case (which is correct) to using kebab case (which is incorrect). Why the change? Did you run the openapi-validator on the updated API definition???
There was a problem hiding this comment.
oh yes, I did generate using the latest API definition, was wondering which could be correct. I will change it back to snake_case.
There was a problem hiding this comment.
@padamstx updated :)
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
pooraniss-ibm
force-pushed
the
iam-identity-account-settings
branch
from
a72dea0
to
90f4b8d
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Nov 23, 2022
# [0.31.0](v0.30.0...v0.31.0) (2022-11-23) ### Features * **IAM Identity:** adding userExpm list and token lifetime ([#221](#221)) ([c9d55a8](c9d55a8))
|
🎉 This PR is included in version 0.31.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
adya1303
pushed a commit
that referenced
this pull request
Dec 6, 2022
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com> Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
adya1303
pushed a commit
that referenced
this pull request
Dec 6, 2022
# [0.31.0](v0.30.0...v0.31.0) (2022-11-23) ### Features * **IAM Identity:** adding userExpm list and token lifetime ([#221](#221)) ([c9d55a8](c9d55a8)) Signed-off-by: ADYA NAND JHA <ADYA.NAND.Jha1@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: poorani poorani.senthilkumar.sankari@ibm.com
PR summary
Adding user exception list and token lifetime to IAM account settings
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Adding user exception list and token lifetime to IAM account settings
Does this PR introduce a breaking change?