Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Activity Tracker v2): add message field Settings struct #226

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

johnymathew
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screen Shot 2022-12-16 at 3 53 36 PM

Screen Shot 2022-12-16 at 3 53 23 PM

@johnymathew johnymathew requested review from veenanr and removed request for yingwang-us December 19, 2022 14:30
@padamstx padamstx self-requested a review December 19, 2022 15:12
@padamstx padamstx self-assigned this Dec 19, 2022
@padamstx padamstx changed the title a message field added to settings struct fix(Activity Tracker v2): add message field Settings struct Dec 19, 2022
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnymathew johnymathew merged commit ccf59a3 into main Dec 19, 2022
@johnymathew johnymathew deleted the msg-update branch December 19, 2022 15:44
ibm-devx-sdk pushed a commit that referenced this pull request Dec 19, 2022
## [0.31.2](v0.31.1...v0.31.2) (2022-12-19)

### Bug Fixes

* **Activity Tracker v2:** add message field Settings struct ([#226](#226)) ([ccf59a3](ccf59a3))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants