Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): Add format query parameter to GET by ID #233

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

swcolley
Copy link
Contributor

PR summary

Add format query parameter to GET by ID for v2 policy. This is needed for terraform provider changes.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Previously missing GET by id query parameter "format", now that has been added for v2/policies. Also minor update to put go sdk in sync with API definition.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx self-assigned this Feb 15, 2023
@padamstx padamstx self-requested a review February 15, 2023 21:35
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 216a92c into main Feb 15, 2023
@padamstx padamstx deleted the v2PolicyPatch branch February 15, 2023 21:51
ibm-devx-sdk pushed a commit that referenced this pull request Feb 15, 2023
## [0.31.5](v0.31.4...v0.31.5) (2023-02-15)

### Bug Fixes

* **IAM Policy Management:** Add format query parameter to GET by ID ([#233](#233)) ([216a92c](216a92c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants