Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): support of new query param source_group_id for v2/roles #243

Merged
merged 2 commits into from
Mar 27, 2023

Conversation

Rajesh-Pirati
Copy link
Contributor

@Rajesh-Pirati Rajesh-Pirati commented Mar 24, 2023

PR summary

V2Roles to support optional query parameter service_group_id
Fixed replacePolicy example

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR's are merged:
Staging: https://github.ibm.com/cloud-api-docs/iam-access-management/pull/162
Production: https://github.ibm.com/cloud-api-docs/iam-access-management/pull/163

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

https://github.ibm.com/IAM/AM-issues/issues/645

Rajesh-Pirati and others added 2 commits March 24, 2023 22:47
…id for v2/roles

fix(IAM Policy Management): Fix replacePolicy example

Signed-off-by: Rajesh K Pirati <Rajesh.Pirati@ibm.com>
@padamstx padamstx self-requested a review March 27, 2023 18:52
@padamstx padamstx self-assigned this Mar 27, 2023
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit f89b2ba into IBM:main Mar 27, 2023
ibm-devx-sdk pushed a commit that referenced this pull request Mar 27, 2023
# [0.33.0](v0.32.2...v0.33.0) (2023-03-27)

### Features

* **IAM Policy Management:** support of new query param source_group_id for v2/roles ([#243](#243)) ([f89b2ba](f89b2ba))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Rajesh-Pirati Rajesh-Pirati deleted the v2Roles-support-serviceGroupId branch April 11, 2023 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants