Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Usage Reports): regen usage reports with latest API def #245

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix(Usage Reports): regen usage reports with latest API def #245

merged 1 commit into from
Apr 5, 2023

Conversation

Jdatechong
Copy link
Contributor

PR summary

Adds the currency_rate and pending fields to various API responses.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Various API response objects should now accurately include the currency_rate and pending fields.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Test results:

•••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 71 of 71 Specs in 2.085 seconds
SUCCESS! -- 71 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  3.252s

Integration test results:

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 80 of 80 Specs in 12.174 seconds
SUCCESS! -- 80 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  13.223s

Examples:

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 80 of 80 Specs in 8.174 seconds
SUCCESS! -- 80 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS
ok      github.com/IBM/platform-services-go-sdk/usagereportsv4  9.044s

@Jdatechong
update usage reports API response fields
ef8e4b1 
Signed-off-by: Jonathan Date-chong <jtdatechong@gmail.com>
@Jdatechong Jdatechong changed the title update usage reports API response fields fix(usage-reports): regen usage reports with latest API def Apr 5, 2023
@padamstx padamstx self-requested a review April 5, 2023 19:21
@padamstx padamstx self-assigned this Apr 5, 2023
@padamstx padamstx changed the title fix(usage-reports): regen usage reports with latest API def fix(Usage Reports): regen usage reports with latest API def Apr 5, 2023
padamstx
padamstx approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 0e1ddc8 into IBM:main Apr 5, 2023
2 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Apr 5, 2023
@semantic-release-bot
chore(release): 0.35.1 release notes [skip ci]
6e5c440 
## [0.35.1](v0.35.0...v0.35.1) (2023-04-05)

### Bug Fixes

* **Usage Reports:** regen usage reports with latest API def ([#245](#245)) ([0e1ddc8](0e1ddc8))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.35.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jdatechong @ibm-devx-sdk @padamstx