fix: enable builds on windows #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
force-pushed
the
add-windows-instructions
branch
2 times, most recently
from
563a6a7
to
960b63d
Compare
|
@michaelbeck Hi Michael, this is the PR for the Go SDK to provide a little more detail for Windows users. I don't think there was really all that much to change, other than including details of the prereqs (note that I am performing these steps in a powershell window within my Windows 11 VM to keep me honest 😂 ). Let me know if you think more details are needed. Thanks! |
This commit updates the project to enable builds to be performed on Windows. I also bumped the go core version to the current latest. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx
force-pushed
the
add-windows-instructions
branch
from
960b63d
to
2f84eaa
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 31, 2023
## [0.47.1](v0.47.0...v0.47.1) (2023-08-31) ### Bug Fixes * enable builds on windows ([#273](#273)) ([b39d2d5](b39d2d5))
|
🎉 This PR is included in version 0.47.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
manukm-ibm
pushed a commit
to manukm-ibm/platform-services-go-sdk
that referenced
this pull request
Sep 13, 2023
This commit updates the project to enable builds to be performed on Windows. I also bumped the go core version to the current latest. Signed-off-by: Phil Adams <phil_adams@us.ibm.com> Signed-off-by: manu.k.m <manu.k.m@ibm.com>
manukm-ibm
pushed a commit
to manukm-ibm/platform-services-go-sdk
that referenced
this pull request
Sep 13, 2023
## [0.47.1](IBM/platform-services-go-sdk@v0.47.0...v0.47.1) (2023-08-31) ### Bug Fixes * enable builds on windows ([IBM#273](IBM#273)) ([b39d2d5](IBM@b39d2d5)) Signed-off-by: manu.k.m <manu.k.m@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This PR updates the project to allow builds to be done on Windows.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information