Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Context-Based Restrictions): add service group support to Operations #277

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

JonahFarc
Copy link
Contributor

PR summary

Adds service group support to operations

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

service_name parameter can now be replaced with the service group parameter.

Does this PR introduce a breaking change?

  • Yes
  • No

Signed-off-by: Dylan <Dylan.Yu@ibm.com>
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please post evidence (screenshot, etc.) of the integration tests and examples runnng clean.

Signed-off-by: Dylan <Dylan.Yu@ibm.com>
@JonahFarc
Copy link
Contributor Author

Successful test runs
image

@JonahFarc
Copy link
Contributor Author

Continuation of examples run
image

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 8ecdfa5 into IBM:main Sep 13, 2023
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Sep 13, 2023
# [0.49.0](v0.48.1...v0.49.0) (2023-09-13)

### Features

* **Context-Based Restrictions:** add service group support to operations ([#277](#277)) ([8ecdfa5](8ecdfa5))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.49.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

manukm-ibm pushed a commit to manukm-ibm/platform-services-go-sdk that referenced this pull request Sep 13, 2023
…ions (IBM#277)

Signed-off-by: Dylan <Dylan.Yu@ibm.com>
Signed-off-by: manu.k.m <manu.k.m@ibm.com>
manukm-ibm pushed a commit to manukm-ibm/platform-services-go-sdk that referenced this pull request Sep 13, 2023
# [0.49.0](IBM/platform-services-go-sdk@v0.48.1...v0.49.0) (2023-09-13)

### Features

* **Context-Based Restrictions:** add service group support to operations ([IBM#277](IBM#277)) ([8ecdfa5](IBM@8ecdfa5))

Signed-off-by: manu.k.m <manu.k.m@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants